Add additional ICD11 providers #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
reviewed
Jan 7, 2025
| @@ -54503,7 +54526,7 @@ | |||
| }, | |||
| "name": "International Classification of Functioning, Disability and Health", | |||
| "pattern": "^\\d+$", | |||
| "uri_format": "http://id.who.int/icd/entity/$1" | |||
| "uri_format": "https://icd.who.int/dev11/l-icf/en#/http://id.who.int/icd/entity/$1" | |||
There was a problem hiding this comment.
definitely correct. Weirdness is a result of web developers who aren't semantic web people.
e.g., https://icd.who.int/dev11/l-icf/en#/http://id.who.int/icd/entity/326705068
| "uri_format": "http://id.who.int/icd/entity/$1" | ||
| }, | ||
| { | ||
| "code": "foundation", |
There was a problem hiding this comment.
Does this mean we will get icd11.foundation as a prefix?
There was a problem hiding this comment.
As I mentioned in the description of this issue, making icd.foundation as a prefix synonym is a discussion for a different issues. The codes in here are only internal, in case you want to resolve to a specific provider you can do https://bioregistry.io/icd11:402558626?provider=foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies that there are several URLs that can resolve for ICD11 codes. It also fixes the ICF URI format string, since it was overlapping and too generic with ICD11.
This PR does not depend on a discussion about the difference between ICD11 numeric identifiers and other codes, like
9D00.2, that appear in the MMS browser.Using Astigmatism (
icd11:402558626) as an example, here are 4 different ways to browse the same numeric identifier:http://id.who.int/icd/entity/$1https://icd.who.int/browse11/l-m/en#/http://id.who.int/icd/entity/$1https://icd.who.int/browse/2024-01/foundation/en#$1https://icd.who.int/browse/2024-01/mms/en#$1This mostly supersedes #1345, but does not add a prefix synonym for "foundation". This can be considered in a different PR.
cc @sierra-moxon