Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: update handling of properties #236

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Breaking: update handling of properties #236

merged 5 commits into from
Nov 21, 2024

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 21, 2024 •
edited
Loading

This PR introduces some breaking changes:

  1. it fixes many bugs in the handling of properties, so the results will change drastically in some cases
  2. splits storage into two new dictionaries - annotations_literal and annotations_object
  3. removes the Term.append_property function and replaces it with two new ones for the two different dictionaries
  4. Changes the datatypes in several of the iterators
  5. Adds datatype handling for annotation properties

@cthoyt cthoyt changed the title Update handling of properties Breaking: update handling of properties Nov 21, 2024
@cthoyt cthoyt marked this pull request as ready for review November 21, 2024 11:58
@cthoyt cthoyt merged commit 8094252 into main Nov 21, 2024
11 checks passed
@cthoyt cthoyt deleted the update-struct branch November 21, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cthoyt