Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline URI and CURIE parsing in the reader #246

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Streamline URI and CURIE parsing in the reader #246

merged 3 commits into from
Nov 25, 2024

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 25, 2024

  1. Rename Reference.from_curie to Reference.from_curie_to_uri. This has the benefit that it can be typed differently, and also reflects its different functionality from the base class.
  2. Updated node iteration to directly construct references. This reduces some superfluous code in indexing them in a mapping
  3. Pass ontology_prefix through to functions where it was missed

@cthoyt cthoyt merged commit c683915 into main Nov 25, 2024
11 checks passed
@cthoyt cthoyt deleted the update-parse branch November 25, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant