Implement axioms on relations, object properties, and xrefs #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
commented
Dec 12, 2024
| term.append_xref(Reference(prefix="ncbitaxon", identifier=ncbitaxon_id)) | ||
| term.append_xref( | ||
| Reference(prefix="ncbitaxon", identifier=ncbitaxon_id), | ||
| # TODO @jose use confidence=... keyword here |
There was a problem hiding this comment.
@jplfaria this is the place where you can write the confidence. If there are some missing SSSOM-like fields you want to use and I can add them in a follow-up PR
term.append_xref(
Reference(prefix="ncbitaxon", identifier=ncbitaxon_id),
confidence=0.99, # or a variable
)
There was a problem hiding this comment.
Thanks I will let you know if I need anything else!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will support making more SSSOM-like mappings through the PyOBO DSL.
Specifically, it will support @jplfaria to annotate some extra information into GTDB (see the TODO in the GTDB source)
Note that most of the functionality and data structures are implemented as private methods and fields. These are subject to change.