Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PubChem version #88

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Update PubChem version #88

merged 2 commits into from
Nov 26, 2020

Conversation

bgyori
Copy link
Contributor

@bgyori bgyori commented Nov 25, 2020

This PR updates the PubChem version. It looks like their FTP server doesn't keep versions older than 4 months, and so the BASE_URL for the 2020-07-02 version doesn't exist anymore.

@bgyori
Copy link
Contributor Author

bgyori commented Nov 25, 2020

Re #89, I added an encoding argument here to be able to run get_pubchem_id_to_name().

@cthoyt
Copy link
Member

cthoyt commented Nov 26, 2020

Thanks for the bump, @bgyori. I had an idea for a general framework for auto-updating versioned resources, which I'll implement when I get back to PyOBO maintenance.

@cthoyt cthoyt merged commit a37e3d7 into biopragmatics:master Nov 26, 2020
@cthoyt
Copy link
Member

cthoyt commented Nov 26, 2020

I made a new release v0.2.15 to go with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants