Data source registration cleanup #361
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 15, 2024 14:24
The grouping of the manager instances in utils with `BaseManager`, `BaseSourceManager` and `JobManager` makes it seem like all three are releated. However, the `BaseManager` and `BaseSourceManager` are only used as parent classes for instantiating different instances within the dataload and dataplugin hub packages. It makes more sense to colocate them together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resolve plugin registration conflicts due to the plugin not being known on the system path and potentially loading a completely different module. Also cleans up some of the organization of the parent managers used within the
dataloadanddatapluginpackages within thehubparent package, as these parent managers are responsible for the registration of all dumper and uploader plugin classes