Provide manifest validation and improved error messages upon invalid plugin manifests #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/biothings.api into add-plugin-architecture-testing
added 8 commits
December 10, 2024 20:59
Template creation is only used via the `do_create` command so we should likely just localize it here for ease of access by the cli module. Should unclutter the `dataplugin` directory
… into dataplugin-assistant-manifest-loading-cleanup
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| dumper_configuration["SET_RELEASE_FUNC"] = "" | ||
|
|
||
| dklass = None | ||
| pnregex = r"^[A-z_][\w\d]+$" |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
jsonschemaand a verbose schema for our dataplugin manifests. Aims to provide better error messaging and ease of verification of the users manifest file