-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse proxy #63
Conversation
@newgene @everaldorodrigo Could you take a look at this branch and see if you can verify that the |
docker/Dockerfile
Outdated
|
||
ENTRYPOINT ["/home/annotator/venv/bin/python", "-m", "biothings_annotator", "--conf=/home/annotator/configuration/default.json"] | ||
ENTRYPOINT ["/home/annotator/venv/bin/python", "-m", "biothings_annotator"] | ||
CMD ["--conf=/home/annotator/configuration/default.json"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrl-schaff @newgene Running in my local we can see the Caddy server in the HTTP response headers below:
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
Content-Length: 1416
Content-Type: text/html; charset=utf-8
Server: Caddy
Date: Fri, 15 Nov 2024 00:17:46 GMT
@@ -34,7 +34,7 @@ | |||
"host": "0.0.0.0", | |||
"motd": true, | |||
"noisy_exceptions": true, | |||
"port": 9000, | |||
"port": 9001, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@everaldorodrigo @ctrl-schaff I think we should keep 9000
port as the default here, but set to 9001
port explicitly from the command line in the docker setup (e.g. at the supervisord conf file).
This way, it's consistent to have 9000
port for either running directly or from docker.
@everaldorodrigo could you do one more spot check on this for me now that we've updated all the ports to what we expect |
No description provided.