Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverse proxy #63

Merged
merged 28 commits into from
Dec 2, 2024
Merged

Add reverse proxy #63

merged 28 commits into from
Dec 2, 2024

Conversation

ctrl-schaff
Copy link
Collaborator

No description provided.

@ctrl-schaff ctrl-schaff added the enhancement New feature or request label Nov 5, 2024
@ctrl-schaff ctrl-schaff requested a review from newgene November 5, 2024 19:31
@ctrl-schaff ctrl-schaff self-assigned this Nov 5, 2024
@ctrl-schaff
Copy link
Collaborator Author

@newgene @everaldorodrigo Could you take a look at this branch and see if you can verify that the reverse_proxy is actually forwarding. This is based off the example chunlei had given me and I've had a decent number of issues getting the docker network to behave on my machine.


ENTRYPOINT ["/home/annotator/venv/bin/python", "-m", "biothings_annotator", "--conf=/home/annotator/configuration/default.json"]
ENTRYPOINT ["/home/annotator/venv/bin/python", "-m", "biothings_annotator"]
CMD ["--conf=/home/annotator/configuration/default.json"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newgene Here is the documentation for the CMD instruction. As well as an accompanying stack overflow post explaining the difference

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrl-schaff @newgene Running in my local we can see the Caddy server in the HTTP response headers below:

HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
Content-Length: 1416
Content-Type: text/html; charset=utf-8
Server: Caddy
Date: Fri, 15 Nov 2024 00:17:46 GMT

@ctrl-schaff ctrl-schaff marked this pull request as ready for review November 7, 2024 19:00
@@ -34,7 +34,7 @@
"host": "0.0.0.0",
"motd": true,
"noisy_exceptions": true,
"port": 9000,
"port": 9001,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@everaldorodrigo @ctrl-schaff I think we should keep 9000 port as the default here, but set to 9001 port explicitly from the command line in the docker setup (e.g. at the supervisord conf file).

This way, it's consistent to have 9000 port for either running directly or from docker.

docker/configuration/supervisord.conf Show resolved Hide resolved
deploy/values.yaml Outdated Show resolved Hide resolved
@ctrl-schaff
Copy link
Collaborator Author

@everaldorodrigo could you do one more spot check on this for me now that we've updated all the ports to what we expect

@ctrl-schaff ctrl-schaff merged commit fa6f375 into main Dec 2, 2024
8 checks passed
@ctrl-schaff ctrl-schaff deleted the add-reverse-proxy branch December 2, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants