React native vb #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavuzcakir
commented
Sep 21, 2022
| @@ -15,7 +15,7 @@ Everyone is welcome to our [Discourse community](https://react-native-webrtc.dis | |||
|
|
|||
| ## WebRTC Revision | |||
|
|
|||
| * Currently used revision: [M100](https://github.com/jitsi/webrtc/releases/tag/v100.0.0) | |||
There was a problem hiding this comment.
please check latest jitsi webrtc version
yavuzcakir
commented
Sep 21, 2022
| @@ -141,13 +141,6 @@ - (instancetype)initWithDelegate:(__weak id<RTCVideoCapturerDelegate>)delegate { | |||
| return self; | |||
| } | |||
|
|
|||
| - (void)setConnection:(SocketConnection *)connection { | |||
There was a problem hiding this comment.
why did you remove it
| @@ -96,6 +100,17 @@ - (void)startCapture { | |||
| dispatch_semaphore_t semaphore = dispatch_semaphore_create(0); | |||
|
|
|||
| __weak VideoCaptureController *weakSelf = self; | |||
|
|
|||
| if (self.vb) { | |||
| // Selfie Segmentator library requires kCVPixelFormatType_32BGRA format | |||
There was a problem hiding this comment.
please update comment with MLKit
| NSDictionary *videoContraints = constraints[@"video"]; | ||
| RTCCameraVideoCapturer *videoCapturer; | ||
|
|
||
| NSLog(@"Video constraint in create video track: %@", videoContraints); |
There was a problem hiding this comment.
Please change NSLog with RCTLog
| @@ -114,6 +130,9 @@ - (RTCVideoTrack *)createScreenCaptureVideoTrack { | |||
| RCT_EXPORT_METHOD(getUserMedia:(NSDictionary *)constraints | |||
| successCallback:(RCTResponseSenderBlock)successCallback | |||
| errorCallback:(RCTResponseSenderBlock)errorCallback) { | |||
|
|
|||
| NSLog(@"Video constraint in RTCMediaStream get user media %@", constraints); | |||
There was a problem hiding this comment.
You can change it with RCTLog
|
HI, can someone please help my problem: https://stackoverflow.com/questions/73554691/react-native-ios-error-build-undefined-symbol-objc-class-selfiesegmentator, I got this error and I can not run this project |
fukemy
approved these changes
Dec 13, 2022
fukemy
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.