feat: add support for Electron based browser for YomiNinja (#1863)

Co-authored-by: Brian Birtles <[email protected]>
birchill · Jul 6, 2024 · 6033168 · 6033168
1 parent b7fc2da
commit 6033168
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/package.json b/package.json
@@ -23,6 +23,7 @@
   "type": "module",
   "scripts": {
     "build:chrome": "webpack --env target=chrome",
+    "build:chrome-electron": "webpack --env target=chrome-electron",
     "build:edge": "webpack --env target=edge",
     "build:firefox": "webpack",
     "build:safari": "webpack --env target=safari",
@@ -34,6 +35,7 @@
     "lint": "web-ext lint && eslint src/",
     "package": "webpack --env package",
     "package:chrome": "webpack --env target=chrome --env package",
+    "package:chrome-electron": "webpack --env target=chrome-electron --env package",
     "package:edge": "webpack --env target=edge --env package",
     "package:firefox": "webpack --env package",
     "package:thunderbird": "webpack --env target=thunderbird --env package",

diff --git a/scripts/build-assets.sh b/scripts/build-assets.sh
@@ -51,6 +51,10 @@ mv dist-firefox-package/10ten_japanese_reader_rikaichamp_-${version}.zip release
 RELEASE_BUILD=1 yarn package:chrome
 mv dist-chrome-package/10ten_japanese_reader_rikaichamp_-${version}.zip release-assets/10ten-ja-reader-${version}-chrome.zip
 
+# Chrome-Electron package
+RELEASE_BUILD=1 yarn package:chrome-electron
+mv dist-chrome-electron-package/10ten_japanese_reader_rikaichamp_-${version}.zip release-assets/10ten-ja-reader-${version}-chrome-electron.zip
+
 # Edge package
 RELEASE_BUILD=1 yarn package:edge
 mv dist-edge-package/10ten_japanese_reader_rikaichamp_-${version}.zip release-assets/10ten-ja-reader-${version}-edge.zip

diff --git a/webpack.config.js b/webpack.config.js
@@ -139,6 +139,23 @@ export default (env) => {
         useServiceWorker: true,
       })
     );
+  } else if (env && env.target === 'chrome-electron') {
+    configs.push(
+      getExtConfig({
+        artifactsDir: 'dist-chrome-electron-package',
+        distFolder: 'dist-chrome-electron',
+        includeRikaichampName: true,
+        isChrome: true,
+        mv3: false,
+        needsClipboardWrite: false,
+        optionsInTab: true,
+        supportsExtensionSourceMaps: false,
+        supportsMatchAboutBlank: true,
+        supportsOfflineEnabledField: true,
+        target: 'chromium',
+        useServiceWorker: false,
+      })
+    );
   } else if (env && env.target === 'edge') {
     configs.push(
       getExtConfig({