Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable local deployment to improve development and testing #484
Enable local deployment to improve development and testing #484
Changes from 1 commit
9f64eb8
d271818
a01c3f6
79445d8
5a6f3b1
9604d5c
5afc7ad
55eecd1
2286baa
6ee2df5
afbcb40
2447c50
7d06949
1156dd7
0466059
e655404
5c3c170
6d6f5ba
3deced4
fcf9ac3
63c55a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the changes are entirely backward compatible.
Before, the
1>&2
redirects were done for specific log levels (WARN and above).This allowed logging outputs to stdout or some file, and only potentially problematic messages to another file. It seems this distinction is not possible anymore, since all goes either to stdout, stderr or the logfile.
Also, if we want both stdout/logfile, we need to ignore both options the script provides, and do
birdhouse [...] | tee logfile
ourselves. It seems like specifying both options should do the same astee
using both outputs simultaneously.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exactly true. Some logs at WARN level and above were redirected to stderr but others weren't. The previous approach was inconsistent.
This can be implemented but it should be done in
logging.include.sh
, not on an ad hoc basis in the files that call the logger. I'm happy to implement this functionality if it's useful.Sure, we can make that work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If some >WARN logs were not redirected, those were unintended bugs.
I agree it should be implemented in
logging.include.sh
.Which levels to log under with std/file output could be controlled by different CLI options, so it doesn't use any hardcoded redirects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are now fully backwards compatible as of e655404