Refactoring/exit startup power #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build artifacts:
|
stylesuxx
requested changes
Sep 23, 2023
stylesuxx
reviewed
Sep 24, 2023
| @@ -1068,9 +1068,6 @@ ENDIF | |||
| ljmp motor_start ; Go back and try starting motors again | |||
|
|
|||
| exit_run_mode_is_stall: | |||
| ; Enable all interrupts (disabled above, in exit_run_mode) | |||
| setb IE_EA | |||
There was a problem hiding this comment.
Can the tidyup of interrupt handling be included in the comment message too please?
There was a problem hiding this comment.
In principle that code has been removed. So you mean to the commit message?
There was a problem hiding this comment.
Done: added interrupt handling explanation in commit comment.
I also squashed the commits in the branch to keep a single comment.
…sabled when entering the function and enabled again when returning. Updated switch_power_off to also set Pwm_Limits to zero to enforce shut down Renamed Pwm_Limit to Pwm_Limit_Startup_n_Temp to make more clear the use of this variable Fixed review findings
damosvil
force-pushed
the
refactoring/exit_startup_power
branch
from
046e949 to
303f638
Compare
hyp0dermik-code
approved these changes
Oct 4, 2023
stylesuxx
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored exit_startup_power to improve coherency.
Updated switch_power_off to also set Pwm_Limits to zero to enforce shut down
Renamed Pwm_Limit to Pwm_Limit_Startup_n_Temp to make more clear the use of this variable