Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define period for max stress level #9

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hyp0dermik-code
Copy link

README.md Outdated Show resolved Hide resolved
@hyp0dermik-code hyp0dermik-code changed the title Defined period for stress frame Define period for stress frame Sep 14, 2024
@hyp0dermik-code hyp0dermik-code changed the title Define period for stress frame Define period for max stress level Sep 14, 2024
@hyp0dermik-code
Copy link
Author

hyp0dermik-code commented Sep 25, 2024

@AlkaMotors have you got any thoughts on this change to the specification? Are you currently using this field? Do you have any future plans for it that should be considered?

If I'm looking in the right place https://github.com/am32-firmware/AM32/blob/300f90ab2ef28346d44c9da52d7f1a2871d21870/Src/main.c#L1940 it would appear it is not currently implemented

@mbuzdalov FYI and any input too. See the linked Bluejay PR also

@mbuzdalov
Copy link

mbuzdalov commented Sep 25, 2024

This indeed makes more sense to reset the maximum each time a frame is sent.

The initial version made some sense too as you could not miss a big stress event, because all subsequent readings would contain it too. However, on some of my machines some motors have a very difficult start, but then function nicely, in which case a high max stress in status was misleading.

From the Ardupilot side, this change should not result in any code change. We accumulate the maximum values for both [0..255] stress and [0..15] stress between log writes (which may happen not too often depending on how logging is configured), but once a log entry is written, the stored maxima are erased anyway.

I will look through what we say in documentation though, and maybe this needs to be slightly updated. Support for EDTv2 still did not reach a stable version anyway, only developer versions have it, so no problem at all.

@hyp0dermik-code
Copy link
Author

hyp0dermik-code commented Sep 26, 2024

@neoxic for your input too

EDIT: ESCape only uses EDTv1 and has no need for EDTv2 at this time, so has no preference

@neoxic
Copy link

neoxic commented Oct 13, 2024

EDIT: ESCape only uses EDTv1 and has no need for EDTv2 at this time, so has no preference

Sorry if it doesn't really belong here, but what I would really appreciate to see in EDT is the way to transmit external/motor temperature. Some ESCs have two temperature sensors (internal and external), and all standard sensored motors have built-in temperature sensors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants