Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PointOfInterest template and added openUrl #153

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

blanck
Copy link

@blanck blanck commented Nov 8, 2023

PointOfInterest template has been updated with:
Parameters

  • primaryButton
  • secondaryButton
  • pinImage
  • selectedPinImage
    Actions
  • setPointsOfInterest
  • setPointOfInterestTitle
    Events
  • didChangeMapRegion

OpenURL method added
Store and connect controller updated to include scene. Required to enable openUrl function to open other apps from an action button. Example to open a navigation app (Maps, Google Maps, Waze) and navigate to a POI.
Example code:
const url = 'maps://?q=London&ll=51.5074256%2C-0.1271814'; CarPlay.openUrl(url);

@birkir
Copy link
Owner

birkir commented Nov 13, 2023

Very nice! Thank you for the contribution.

@birkir
Copy link
Owner

birkir commented Nov 18, 2023

We are getting lockfile conflict because of "react-native": "" and "react": ""

Any reason for the change?

image

Once tests pass I'll merge!

@ElangoPrince
Copy link

ElangoPrince commented Nov 24, 2023

@birkir Have you merged this changes? If not kindly merge those changes. Stuck on POI Template.

@birkir
Copy link
Owner

birkir commented Nov 24, 2023

@birkir Have you merged this changes? If not kindly merge those changes. Stuck on POI Template.

It's not ready as far as I'm concerned.

@ElangoPrince
Copy link

@birkir Ohh, Okay. I'm waiting for this update. Its blocking me to proceed further. Can you give any possible way to use POI for now?

@birkir
Copy link
Owner

birkir commented Nov 24, 2023

You can easily apply patches to any packages if you want.
If using yarn 2+ you can use yarn patch
Otherwise you can use patch-package

Feel free to use changes from this PR

@saikiranm33
Copy link

@blanck still seeing the unsupported object issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants