Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary fix for ros bags once possible #266

Closed
phinik opened this issue Sep 20, 2023 · 5 comments · Fixed by #372
Closed

Remove temporary fix for ros bags once possible #266

phinik opened this issue Sep 20, 2023 · 5 comments · Fixed by #372
Labels
enhancement New feature or request vision

Comments

@phinik
Copy link
Member

phinik commented Sep 20, 2023

Is your feature request related to a problem? Please describe.

Just a reminder

Describe the solution you'd like

Remove temporary fix for ros bags once possible (bit-bots/bitbots_vision#343)

Describe alternatives you've considered
@phinik phinik added the enhancement New feature or request label Sep 20, 2023
@Flova
Copy link
Member

Flova commented Sep 21, 2023

Good point. As this is a Middleware issue we might want to link the upstream issue. Do you know which one it is? @timonegk @jaagut

@jaagut
Copy link
Member

jaagut commented Sep 21, 2023

ros2/rmw_cyclonedds#461

1 similar comment
@Flova
Copy link
Member

Flova commented Sep 21, 2023

ros2/rmw_cyclonedds#461

@Flova
Copy link
Member

Flova commented Sep 21, 2023

A nvm you are faster

@Flova
Copy link
Member

Flova commented Sep 21, 2023

Seems like we need to test this again and answer

@jaagut jaagut transferred this issue from bit-bots/bitbots_vision Jan 23, 2024
@Flova Flova added the vision label Jan 24, 2024
@jaagut jaagut moved this from 📋 Backlog to 🏗 In progress in Software Apr 2, 2024
@jaagut jaagut moved this from 🏗 In progress to 🔖 Ready in Software Apr 2, 2024
@Flova Flova mentioned this issue Apr 5, 2024
Merged
6 tasks
@Flova Flova closed this as completed in #372 Apr 5, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Software Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request vision
Projects
Software
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert fix for wm 2023 and remove unused code bit-bots/bitbots_main
3 participants
@Flova @phinik @jaagut