Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module enabled check to plugin enabled #228

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

rikwillems
Copy link
Contributor

Fixes #182

@shochdoerfer shochdoerfer added this to the 5.2.0 milestone Oct 10, 2023
@shochdoerfer
Copy link
Member

Thx @rikwillems for helping out!

@rikwillems
Copy link
Contributor Author

@shochdoerfer you're welcome! Not sure what to make of the pipeline issues though.

Error: Ignored error pattern ~Parameter #3 \$data of method~ in path /home/runner/work/magento2-force-login/magento2-force-login/Block/Adminhtml/Manage/Create.php was not matched in reported errors.
This seems to be an ignore that can be removed.

Error: Method BitExpert\ForceCustomerLogin\Controller\LoginRouter::match() should return Magento\Framework\App\ActionInterface|void but returns Magento\Framework\App\Action.
This seems to be valid to me?

Error: Parameter #1 $data of method Magento\Framework\App\ActionFactory::create() expects array, string given.
This seems to be untrue, the factory expects a string as far as I can see.

@shochdoerfer
Copy link
Member

@rikwillems let me check later this week, I am currently traveling and don't have access to all the tools :)

@shochdoerfer
Copy link
Member

@rikwillems I also think you can remove the Ignored error pattern ~Parameter #3 \$data from PHPStan's ignoreErrors configuration, probably something that was fixed in a recent Magento version.

For the other 2 errors I don't understand why those happen. You could try to update the bitexpert/phpstan-magento dependency to the latest version and see if the errors disappear. Also, it might make sense to upgrade PHPStan to a more recent version, the used version 1.7 is rather old. If that does not help, I would add both errors the ignoreErrors configuration. Given both are not showstoppers, that would be "ok" for me.

@rikwillems
Copy link
Contributor Author

@shochdoerfer I removed the ignored error. The other two are solved by upgrading PHPStan.

# Conflicts:
#	composer.json
@coveralls
Copy link

Coverage Status

coverage: 58.317% (+0.2%) from 58.071% when pulling 143eaac on rikwillems:pr/issue-182 into 4e2d8e9 on bitExpert:master.

@shochdoerfer shochdoerfer merged commit e06f7a9 into bitExpert:master Oct 16, 2023
8 checks passed
@shochdoerfer
Copy link
Member

Awesome! Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module not enabled but redirect to homepage
3 participants