MISC: Several typo fix in corporation modals #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that Prettier prevents change in L37. Why? |
jjclark1982
reviewed
Jan 10, 2024
| <Typography>Cities:{getRecordKeys(divisionToSell.offices).length}</Typography> | ||
| <Typography>Warehouses:{getRecordKeys(divisionToSell.warehouses).length}</Typography> | ||
| <Typography>Cities: {getRecordKeys(divisionToSell.offices).length}</Typography> | ||
| <Typography>Warehouses: {getRecordKeys(divisionToSell.warehouses).length}</Typography> |
There was a problem hiding this comment.
This section might look better as a <StatsTable>, which automatically aligns the right column.
It enforces a maximum line length, but it usually inserts a space character |
|
Thanks a lot. It seems to be better now. Without products: |
Fix Prettier failure. Use StatsTable to align columns. Fix misused ?? operator to show "Products" when the division is capable to produce them.
Add `key` to element in array.
Finally, used Prettier and checked with format:report
G4mingJon4s
pushed a commit
to G4mingJon4s/bitburner-src
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing space between sentences in PurchaseMaterialModal when Smart Supply is enabled:
Tested locally:
Missing space between colon and number in SellDivisionModal:
Tested locally:
Missing space between "for" and number:
Tested locally:
