DOCUMENTATION: Fix incorrectly documented BusinessFactor #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The advanced documentation incorrectly claims that the multiplier is 0.001. The actual code divides by 10000 (10e3), effectively multiplying by 0.0001: https://github.com/bitburner-official/bitburner-src/blob/dev/src/Corporation/Division.ts#L1085 Perhaps the author confused 10e3 and 1e3, or the code changed since the guide was written?
|
Yeah. It's a typo. |
antoinedube
pushed a commit
to antoinedube/bitburner-source
that referenced
this pull request
Feb 1, 2025
…fficial#1915) The advanced documentation incorrectly claims that the multiplier is 0.001. The actual code divides by 10000 (10e3), effectively multiplying by 0.0001: https://github.com/bitburner-official/bitburner-src/blob/dev/src/Corporation/Division.ts#L1085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advanced documentation incorrectly claims that the multiplier is 0.001. The actual code divides by 10000 (10e3), effectively multiplying by 0.0001:
https://github.com/bitburner-official/bitburner-src/blob/dev/src/Corporation/Division.ts#L1085
Perhaps the author confused 10e3 and 1e3, or the code changed since the guide was written?
Tested in trial by fire while developing my (incomplete) corporation management script, and wondering why the heck the numbers weren't lining up.
esainane/bitburner-scripts@22712cd39e5a:src/corp.ts#L111