Skip to content

Commit

Permalink
Merge #715: add support for Python 3.12
Browse files Browse the repository at this point in the history
b191299 add support for Python 3.12 (Filip Gospodinov)

Pull request description:

  Fedora 39 ships with Python 3.12. To achieve a better out-of-the-box experience, support for Python 3.12 is added. This required `pyinstaller` and `hidapi` to be updated.

  `pyinstaller` has dropped support for Python 3.7 because it reached EOL on on 2023-06-27 [1]. The `pyinstaller` update forces us to also drop support for Python 3.7. Considering that HWI is a security-sensitive package it makes sense to stop using EOL software components.

  ~~`hidapi` is missing a release that works with Python 3.12 [2] so we depend on a git version for now.~~
  `hidapi` is missing a release that works on Alpine Linux [2] but this is an orthogonal issue.

  [1] pyinstaller/pyinstaller@da33dbf
  [2] trezor/cython-hidapi#168

ACKs for top commit:
  achow101:
    ACK b191299

Tree-SHA512: d3d5d9212af873bbd03d57dfe7b911af342f26eca3d4dddc12ed218f5e9f05c13ce23ea74495bc8d897e2db0ad3ccbcd772ca785be57ec395218fc9d43ded0bb
  • Loading branch information
achow101 committed Jan 17, 2024
2 parents 59eeb85 + b191299 commit e817415
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 29 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ '3.7', '3.8', '3.9', '3.10', '3.11' ]
python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12' ]
device:
- 'trezor-1'
- 'trezor-t'
Expand Down Expand Up @@ -276,7 +276,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ '3.7', '3.8', '3.9', '3.10', '3.11' ]
python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12' ]
device:
- 'trezor-1'
- 'trezor-t'
Expand Down
56 changes: 32 additions & 24 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ packages = [
]

[tool.poetry.dependencies]
python = "^3.7,<3.12"
python = "^3.8,<3.13"
hidapi = ">=0.14.0"
ecdsa = "~0"
pyaes = "^1.6"
Expand All @@ -35,7 +35,7 @@ protobuf = "^4.23.3"
qt = ["pyside2"]

[tool.poetry.dev-dependencies]
pyinstaller = "^5.3"
pyinstaller = "^6.3"
autopep8 = "~1"
flake8 = ">=3"
mypy = "~0"
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
'install_requires': install_requires,
'extras_require': extras_require,
'entry_points': entry_points,
'python_requires': '>=3.7,<3.12',
'python_requires': '>=3.8,<3.13',
}


Expand Down

0 comments on commit e817415

Please sign in to comment.