Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement createSingleSigWallet #444

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Implement createSingleSigWallet #444

merged 1 commit into from
Feb 20, 2025

Conversation

davidgumberg
Copy link
Contributor

Although imperfect, this PR enables completion of the wallet creation flow by implementing createSingleSigWallet. Useful for testing #418.

johnny9
johnny9 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK be612b0

tested on Ubuntu with "-signet -resetguisettings"

Thanks for fixing this. Looks like this method somehow got lost when we moved the module.

@hebasto hebasto changed the title qml: Implement createSingleSigWallet Implement createSingleSigWallet Feb 20, 2025
@hebasto hebasto merged commit a8d15db into bitcoin-core:main Feb 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnny9 johnny9 johnny9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgumberg @johnny9 @hebasto