Skip to content

Adding an abort trigger and changing how tasks shutdown #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Adding an abort trigger and changing how tasks shutdown #230

wants to merge 3 commits into from

Conversation

bjohnson5
Copy link
Collaborator

Closes #222

@bjohnson5 bjohnson5 mentioned this pull request Mar 11, 2025
Open
@bjohnson5 bjohnson5 requested a review from carlaKC March 17, 2025 15:49
@bjohnson5 bjohnson5 marked this pull request as ready for review March 17, 2025 15:50
carlaKC
carlaKC reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this dropped out of my queue, added a comment in the tracking issue to discuss approach.

@bjohnson5 bjohnson5 closed this Mar 21, 2025
@bjohnson5 bjohnson5 deleted the 222-payment-count-fix branch April 23, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlaKC carlaKC carlaKC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: count in defined activity produces count-1 events (one less than expected)
2 participants
@bjohnson5 @carlaKC