Skip to content

cli: add 'port_forward' subcommand for ln #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

f3r10
Copy link

@f3r10 f3r10 commented Mar 2, 2025

Add a subcommand for port forwarding from ln pods to a local port so a ln pod can be referenced from the host machine.

@pinheadmz
Copy link
Contributor

Thanks for contribution! And sorry about the linter, everyone hates it (sigh) see https://github.com/bitcoin-dev-project/warnet/blob/main/docs/developer-notes.md#formatting--linting

Since you're using stream_command it's blocking -- which is fine if you only need one at a time, how have you been dealing with simln and (I assume) a cluster of LN nodes? It might make more sense to even spawn a pool of threads for all the nodes, maybe even spit out a config file for simln

@f3r10
Copy link
Author

f3r10 commented Mar 11, 2025

yes, you are right it would be better to spawn a pool of threads for all the nodes, I will update that part.

@bdp-DrahtBot bdp-DrahtBot mentioned this pull request Apr 23, 2025
@bdp-DrahtBot
Copy link
Collaborator

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #713 (Add CLN support by macgyver13)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants