64bit arith inquisition #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework IsOpSuccess() to use SigVersion rather than leaf_version Use switch based impl for IsOpSuccess() Remove default in switch statement Fix compiler warning Move SigVersion to sigversion.h Fix includes try to fix compile Add sigversion.h Add include guards
…ESSTHANOREQUAL64, OP_GREATERTHAN64, OP_GREATERTHANOREQUAL64, OP_SCRIPTNUMTOLE64, OP_LE64TOSCRIPTNUM, OP_LE32TOLE64 Remove liquid args WIP Get simple OP_1 functional test case working Get tests for arithmetic and comparison opcodes working Get all functional tests passing Rename test case to Arithmetic64bitTest Rename file to feature_64bit_arithmetic_opcodes.py, add it to test_runner.py Get tests passing in feature_taproot.py Remove unused push_le4 Revert test fixture setup Cleanup Fix linting test: Add leaf_version parameter to taproot_tree_helper() Fix bug Fix bugs Fix compile Fix missing sigversion checks Fix htole64 -> htole64_internal due to bitcoin#29263
…d in 27.x of bitcoin core
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #48 and targets 26.x of bitcoin core. It looks like there is a ton of conflicts if I were to target 25.x .
This PRs implements signed integer 64 bit arithmetic in the Script interpreter.
It corresponds to this PR on the bitcoin core repo and this delving bitcoin discussion: bitcoin#29221
It corresponds to this BIP pull req: bitcoin/bips#1538
This implementation purposefully avoids using
CScriptNum, if you would like to see what aCScriptNumimplementation looks like, please see this branch: https://github.com/Christewart/bitcoin/tree/64bit-arith-cscriptnumIf you would like to see usage of these op codes, please see my
OP_INOUT_AMOUNTimplementation and delving bitcoin discussion: https://github.com/Christewart/bitcoin/tree/op-inout-amount