Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP_INOUT_AMOUNT inquisition #50

Closed
wants to merge 4 commits into from
Closed

OP_INOUT_AMOUNT inquisition #50

wants to merge 4 commits into from

Commits on Mar 13, 2024

  1. Add SigVersion parameter to IsOpSuccess() 

    Rework IsOpSuccess() to use SigVersion rather than leaf_version

Use switch based impl for IsOpSuccess()

Remove default in switch statement

Fix compiler warning

Move SigVersion to sigversion.h

Fix includes

try to fix compile

Add sigversion.h

Add include guards
    @Christewart
    Christewart committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3beb236 View commit details
    Browse the repository at this point in the history

  2. Implement OP_ADD64, OP_SUB64, OP_MUL64, OP_DIV64, OP_LESSTHAN64, OP_L… 

    …ESSTHANOREQUAL64, OP_GREATERTHAN64, OP_GREATERTHANOREQUAL64, OP_SCRIPTNUMTOLE64, OP_LE64TOSCRIPTNUM, OP_LE32TOLE64

Remove liquid args

WIP

Get simple OP_1 functional test case working

Get tests for arithmetic and comparison opcodes working

Get all functional tests passing

Rename test case to Arithmetic64bitTest

Rename file to feature_64bit_arithmetic_opcodes.py, add it to test_runner.py

Get tests passing in feature_taproot.py

Remove unused push_le4

Revert test fixture setup

Cleanup

Fix linting

test: Add leaf_version parameter to taproot_tree_helper()

Fix bug

Fix bugs

Fix compile

Fix missing sigversion checks

Fix htole64 -> htole64_internal due to bitcoin#29263
    @Christewart
    Christewart committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4b2dedb View commit details
    Browse the repository at this point in the history

  3. Revert htole64_internal -> htole64, as this is is a feature introduce… 

    …d in 27.x of bitcoin core
    @Christewart
    Christewart committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7affba6 View commit details
    Browse the repository at this point in the history

  4. OP_INOUT_AMOUNT 

    Get things compiling

Get basic OP_INOUT_AMOUNT impl

Get scaffolding for python test feature_inout_amount.py

Add amount param

Get two simple test cases working checking we aren't withdrawing more than 1BTC

Fix test failure

Remove comments

Cleanup interpreter.cpp
    @Christewart
    Christewart committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4b90d5a View commit details
    Browse the repository at this point in the history