Add OP_TXHASH and OP_CHECKTXHASHVERIFY #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
If you want to poke at this again, you probably want to bump to the 27.x branch. |
|
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
1 similar comment
|
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the TXHASH BIP this is modeled after: Add BIP for OP_TXHASH and OP_CHECKTXHASHVERIFY bitcoin/bips#1500
the Bitcoin Core MR this is a port of: Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes bitcoin/bitcoin#29050
I changed the opcode that
OP_CHECKTXHASHVERIFYwould be replacing fromOP_NOP4toOP_NOP5.