Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1478): migrate existing admin v2 endpoints to openapi3 #899

Merged
merged 20 commits into from
Feb 14, 2025

Conversation

pawellewandowski98
Copy link
Contributor

@pawellewandowski98 pawellewandowski98 commented Feb 8, 2025

Description

  • Migrate existing admin v2 endpoints to openapi3 implementation

Warning

Remember to regenerate swagger when #898 is merged

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Feb 8, 2025
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner February 8, 2025 12:58
Copy link

github-actions bot commented Feb 8, 2025

Manual Tests

💚 Manual testing by @dorzepowski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 43.26531% with 139 lines in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (c72a4cf) to head (0b22239).

Files with missing lines Patch % Lines
api/gen.models.go 0.00% 104 Missing ⚠️
api/gen.api.go 76.66% 10 Missing and 4 partials ⚠️
server/server.go 0.00% 9 Missing ⚠️
tools/merge_yamls.go 0.00% 5 Missing ⚠️
actions/v2/admin/users/create.go 75.00% 3 Missing and 1 partial ⚠️
actions/v2/admin/users/paymail_add.go 89.47% 1 Missing and 1 partial ⚠️
actions/v2/admin/users/get.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
- Coverage   53.25%   53.05%   -0.21%     
==========================================
  Files         412      409       -3     
  Lines       18359    18498     +139     
==========================================
+ Hits         9778     9815      +37     
- Misses       7815     7913      +98     
- Partials      766      770       +4     
Flag Coverage Δ
unittests 53.05% <43.26%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/v2/admin/internal/mapping/paymail.go 100.00% <100.00%> (ø)
actions/v2/admin/internal/mapping/user.go 100.00% <100.00%> (ø)
actions/v2/admin/server.go 100.00% <100.00%> (ø)
actions/v2/admin/status.go 100.00% <100.00%> (ø)
actions/v2/admin/users/server.go 100.00% <100.00%> (ø)
actions/v2/base/server.go 100.00% <100.00%> (ø)
actions/v2/base/shared_config.go 100.00% <100.00%> (ø)
actions/v2/register.go 100.00% <100.00%> (ø)
actions/v2/server.go 100.00% <100.00%> (ø)
actions/v2/swagger/swagger-ui.go 62.50% <ø> (ø)
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72a4cf...0b22239. Read the comment docs.

actions/v2/admin/server.go Outdated Show resolved Hide resolved
actions/v2/server.go Outdated Show resolved Hide resolved
api/endpoints/admin.yaml Outdated Show resolved Hide resolved
api/gen.api.yaml Outdated Show resolved Hide resolved
…-admin-endpoints

# Conflicts:
#	actions/v2/admin/server.go
#	actions/v2/server.go
#	api/components/models.yaml
#	api/components/responses.yaml
#	api/gen.api.go
#	api/gen.api.yaml
#	api/gen.models.go
#	server/server.go
tools/merge_yamls.go Outdated Show resolved Hide resolved
@dorzepowski dorzepowski added the tested PR was tested by a team member label Feb 14, 2025
@dorzepowski dorzepowski force-pushed the feat/SPV-1478-migrate-admin-endpoints branch from d0baa6f to a4b742b Compare February 14, 2025 09:56
@dorzepowski dorzepowski added tested PR was tested by a team member and removed tested PR was tested by a team member labels Feb 14, 2025
@dorzepowski dorzepowski added tested PR was tested by a team member and removed tested PR was tested by a team member labels Feb 14, 2025
@dorzepowski dorzepowski merged commit 7d14887 into main Feb 14, 2025
13 of 14 checks passed
@dorzepowski dorzepowski deleted the feat/SPV-1478-migrate-admin-endpoints branch February 14, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants