Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP352: Add support for Pay-to-Anchor (P2A) in get_pubkey_from_input #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BIP352: Add support for Pay-to-Anchor (P2A) in get_pubkey_from_input #1707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bip-0352/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ def get_pubkey_from_input(vin: VinInfo) -> ECPubKey:
pubkey = ECPubKey().set(vin.prevout[2:])
if (pubkey.valid) & (pubkey.compressed):
return pubkey
if is_p2a(vin.prevout):
anchor_script = vin.scriptSig[1:]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scriptSig for segwit spends is always empty by consensus rules, so this line doesn't make sense (see also https://bitcoin.stackexchange.com/questions/124615/is-the-scriptsig-spending-an-paytoanchor-output-expected-to-always-be-empty).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm interesting, so it's best to close this PR then?

pubkey = ECPubKey().set(anchor_script)
if (pubkey.valid) & (pubkey.compressed):
return pubkey


return ECPubKey()
Expand Down