Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add addrman peers.dat test #22877

Closed
wants to merge 2 commits into from
Closed

test: Add addrman peers.dat test #22877

wants to merge 2 commits into from

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Sep 3, 2021 •
edited
Loading

No description provided.

@maflcko
Copy link
Member Author

maflcko commented Sep 3, 2021

@jonatack #22762 (comment)

jonatack
jonatack reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, concept ACK. Some initial ideas below.

test/functional/feature_addrman.py Outdated Show resolved Hide resolved
test/functional/feature_addrman.py Outdated Show resolved Hide resolved
@maflcko
Copy link
Member Author

maflcko commented Sep 3, 2021 •
edited
Loading

Force pushed to address feedback

@jonatack
Copy link
Member

jonatack commented Sep 3, 2021

I wrote some follow-ups last weekend to #22831 to add more addrman tests and rename feature_asmap.py to feature_addrman_asmap.py as they are related features, but didn't want to add them to that pull to keep it focused on just fixing the bug with regression tests.

@maflcko
Copy link
Member Author

maflcko commented Sep 3, 2021

Looks like there is some kind of compiler bug or compiler behaviour change

@maflcko maflcko closed this Sep 3, 2021
@maflcko
Copy link
Member Author

maflcko commented Sep 3, 2021

Reported issue in c42f/tinyformat#82, worked around issue in #22879

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonatack jonatack jonatack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maflcko @jonatack