Fix for Windows build using MSVC #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luke-jr 🏓 |
This comment was marked as spam.
This comment was marked as spam.
hernanrz
added a commit
to hernanrz/libaergo
that referenced
this pull request
Dec 17, 2022
based on this patch bitcoin/libbase58#12
hernanrz
added a commit
to hernanrz/libaergo
that referenced
this pull request
Dec 18, 2022
based on this patch bitcoin/libbase58#12 make aergo.h compile on MSVC add dll entrypoint for windows copied from https://github.com/aergoio/secp256k1-vrf/blob/master/.github/workflows/build.yml#L34 windows compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable length arrays are not supported by MSVC. Fall back to malloc.
Based on the fix by holland01 #7, but
goto. Instead do afreefor eachreturn. (Ignored for GCC build.)