Skip to content

Kyoto: Remove connection requirement to send tx #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

Kyoto: Remove connection requirement to send tx #202

merged 1 commit into from
Jun 18, 2025

Conversation

rustaceanrob
Copy link
Contributor

@rustaceanrob rustaceanrob commented Jun 17, 2025 •
edited
Loading

Kyoto now holds on to a transaction internally until it is successfully broadcast, so we can broadcast the transaction immediately once the node starts up, and wait for a confirmation or 30 second timeout

Successful test on Signet. Note that Testnet4 still has the difficulty adjustment bug when loading block headers from storage.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@rustaceanrob rustaceanrob force-pushed the kyoto-broadcast-6-17 branch from bab0d8b to 6ca7372 Compare June 17, 2025 12:41
@coveralls
Copy link

coveralls commented Jun 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15730343098

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 2.674%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 15624730149: 0.01%
Covered Lines: 25
Relevant Lines: 935
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15707490095

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 2.671%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers.rs 0 4 0.0%
Totals Coverage Status
Change from base Build 15624730149: 0.01%
Covered Lines: 25
Relevant Lines: 936
💛 - Coveralls

@notmandatory notmandatory added this to the CLI 1.1.0 milestone Jun 17, 2025
@notmandatory notmandatory moved this to Ready to Review in BDK-CLI Jun 17, 2025
@notmandatory notmandatory added the enhancement New feature or request label Jun 17, 2025
@notmandatory notmandatory requested a review from tvpeter June 17, 2025 22:11
notmandatory
notmandatory approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6ca7372

tvpeter
tvpeter reviewed Jun 18, 2025
View reviewed changes
tvpeter
tvpeter approved these changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@tvpeter tvpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 6ca7372

Thank you for updating this, Rob. Successfully tested on signet.

nit: I will update the timeout error message if you don't have time before merging.

@rustaceanrob
fix(kyoto): remove conn requirement to send tx
3b60b7b 
Kyoto now holds on to a transaction internally until it is successfully
broadcast, so we can broadcast the transaction immediately once the node
starts up, and wait for a confirmation or 30 second timeout
@rustaceanrob rustaceanrob force-pushed the kyoto-broadcast-6-17 branch from 6ca7372 to 3b60b7b Compare June 18, 2025 10:25
@rustaceanrob
Copy link
Contributor Author

Updated the error message as well as the irrelevant tracing message

@tvpeter
Copy link
Collaborator

tvpeter commented Jun 18, 2025

Thank you @rustaceanrob

@tvpeter tvpeter merged commit 7a71b14 into bitcoindevkit:master Jun 18, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in BDK-CLI Jun 18, 2025
@rustaceanrob rustaceanrob deleted the kyoto-broadcast-6-17 branch June 18, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@tvpeter tvpeter tvpeter approved these changes

Assignees

@rustaceanrob rustaceanrob

Labels
enhancement New feature or request
Projects
BDK-CLI
Status: Done
Milestone
CLI 1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rustaceanrob @coveralls @tvpeter @notmandatory