Make scanning requirements explicit #100
Open
+58
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustaceanrob
force-pushed
the
recovery-1-25
branch
2 times, most recently
from
1ccc474 to
68106ef
Compare
rustaceanrob
force-pushed
the
recovery-1-25
branch
from
68106ef to
60da279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bit of guess-work going on when the user provides a wallet birthday. If the local chain tip is at height 0, then it is assumed that the user is trying to either 1. recover from the provided birthday 2. sync the chain from the latest checkpoint because its a new wallet. This is a little dangerous because a poor implementation may not configure the birthday, and would miss the old transactions. Also the code is convoluted and hard to reason about. To get around both of these, a
ScanTypeis introduced to force the developer to specify what it is they are doing. If the implementation neglects this type and a user is trying to recover a wallet, the scan will start from height 0. To explicitly ignore old block headers and start a new wallet, one would passScanType::Newedit: I preserved the
scan_aftermethod on the builder, so this can technically be released as a patch release to the best of my semver knowledge