Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/0.29, deps: Update rusqlite to 0.31 #1651

Merged
merged 2 commits into from
Nov 23, 2024
Merged

release/0.29, deps: Update rusqlite to 0.31 #1651

merged 2 commits into from
Nov 23, 2024

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Oct 17, 2024 •
edited
Loading

Description

Builds on v0.29.0, the PR updates rusqlite dependency to 0.31.

The idea is that it will help facilitate the wallet migration process outlined in #1648

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory modified the milestones: 0.29.1, 0.30.0 Oct 21, 2024
@notmandatory notmandatory force-pushed the release/0.29-deps-rusqlite branch from bac25d5 to 56b32da Compare October 22, 2024 01:47
@notmandatory
Copy link
Member

@ValuedMammal I rebased your branch, it should be ready to go now to test with your migration example.

@ValuedMammal ValuedMammal marked this pull request as ready for review October 22, 2024 15:02
@ValuedMammal ValuedMammal mentioned this pull request Oct 22, 2024
Draft
3 tasks
notmandatory
notmandatory approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b7dad9f

@notmandatory notmandatory force-pushed the release/0.29-deps-rusqlite branch from 61b9f94 to b7dad9f Compare November 22, 2024 23:03
@notmandatory notmandatory merged commit b7dad9f into bitcoindevkit:release/0.29 Nov 23, 2024
78 checks passed
@notmandatory notmandatory mentioned this pull request Nov 23, 2024
Merged
3 tasks
@ValuedMammal ValuedMammal deleted the release/0.29-deps-rusqlite branch November 25, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels
chore module-wallet
Projects
BDK
Archived in project
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ValuedMammal @notmandatory