Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Gudnessuche
Copy link

minor updates

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

minor updates
@LagginTimes LagginTimes added the documentation Improvements or additions to documentation label Dec 6, 2024
@notmandatory
Copy link
Member

Thanks for these small doc fixes, but I suggest you start with something a little more substantial. Minor grammar and punctuation fixes aren't a good way to start contributing to a project. It's better to find an issue where you can demonstrate some knowledge of bitcoin or the code base, such as improving the substance of documentation, testing, or fixing some small issue even if it's considered low priority.

@Gudnessuche
Copy link
Author

I agree with you @notmandatory.
I have actually followed and built a wallet following BDK's Youtube tutorial to do so with React, as well as how to use the bdk cli(All taught by Conor Okus)
I was reading on Silent Payment and saw on their site that BDK needed a PR merged for it, so I felt the best place to start was the README.md file and then came across errors I felt needed correcting.
I am trying to port a certain rust library for Silent Payments to BDK's to enable Silent Payment sending option. That's the main reason I am here. I sufficiently understand how the moving parts work.
Pls merge the PRs, while I keep stacking more technical PRs.

PS: Also contributing to Bitshala's Silent Payment repo, since that's in TS.

@thunderbiscuit
Copy link
Member

See #1762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants