Refactor timeout builder to accept Option<Duration> #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the timeout builder logic to accept Option instead of requiring a concrete Duration. This change improves flexibility for client configuration, allowing consumers to opt out of setting a timeout when desired.
🔧 Changes Made
Motivation
This change aligns with Issue Timeout should be set with a std::time::Duration #151 and improves ergonomics for downstream users who may not always need a timeout. It also simplifies integration with wallet builders and other client abstractions.
Linked Issue
Closes Timeout should be set with a std::time::Duration #151