Fixed missing .js to imports #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Node.js, if you're working with ES Modules (.mjs files or .js files with "type": "module" in your package.json), you are required to include the .js extension in your import paths. Unfortunately, Node.js strictly enforces this rule for ES Modules, and there's no built-in way to make Node.js automatically resolve imports without the .js extension in this mode.
junderw
requested changes
Oct 18, 2024
There was a problem hiding this comment.
See comments. Also, please add a test of some sort.
Ideally a bash script or something that makes a simple project in a temp folder that just tries to import this repository (via file install) and fails to build.
I will verify that it fails on my PC, and that this PR doesn't fail.
Then we can have it run in CI to make sure we don't mess up the hybrid package when making changes.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ecpair", | |||
| "version": "3.0.0-rc.0", | |||
| "version": "3.0.1-rc.0", | |||
| @@ -0,0 +1,5 @@ | |||
| # Default ignored files | |||
| /shelf/ | |||
There was a problem hiding this comment.
Don't commit .idea folder please
|
There's a broken lint in the tests... also we should update the node version used in CI to something that has the crypto API (to stop the errors) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node.js, if you're working with ES Modules (.mjs files or .js files with "type": "module" in your package.json), you are required to include the .js extension in your import paths. Unfortunately, Node.js strictly enforces this rule for ES Modules, and there's no built-in way to make Node.js automatically resolve imports without the .js extension in this mode.
If you create a typescript project in mode module and try to use this package, you will get the following error:
Cannot find module 'node_modules\ecpair\src\esm\ecpair' imported from node_modules\ecpair\src\esm\index.js