Create specific HREF definition for HrefListProperty
#105
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the HREF constant definition by moving it from DavResource.Companion to HrefListProperty.Companion, improving code organization and reducing coupling between classes.
Key changes:
- Added
HREFconstant toHrefListProperty.Companion - Updated references within
HrefListPropertyto use the localHREFconstant - Removed dependency on
DavResourceimport inHrefListProperty
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…perty.kt Co-authored-by: Copilot <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
|
@sunkup should be good |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import kotlin.text.Charsets | ||
| import kotlin.text.toByteArray | ||
| import kotlin.text.trim |
There was a problem hiding this comment.
These explicit imports from kotlin.text are unnecessary as these are part of Kotlin's standard library and should be available without explicit imports. The Charsets, toByteArray(), and trim() functions are automatically imported by Kotlin. Consider removing these imports.
| import kotlin.text.Charsets | |
| import kotlin.text.toByteArray | |
| import kotlin.text.trim |
There was a problem hiding this comment.
Why the deprecation warnings? The HREF attributes are not being used in DAVx⁵ and I don't know any project using dav4jvm besides DAVx⁵. I understand the idea in doing it "properly", but it creates the problem/work of us having to remove the deprecation at some point in the future again too ...
2 participants
No description provided.