Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UninitializedPropertyAccessException when destroying the Player #598

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Fix UninitializedPropertyAccessException when destroying the Player #598

merged 3 commits into from
Jan 15, 2025
+15 −8

Conversation

testcenter
Copy link
Contributor

Description

When a player with the config mediaControlConfig.isEnabled = false is created and the player gets destroyed, it will throw an UninitializedPropertyAccessException while trying to destroy the MediaSessionPlaybackManager

Changes

  • Change MediaSessionPlaybackManager.playerId from lateinit to nullable.
  • Remove unnecessary resolveOnUiThread call

Checklist

  • 🗒 CHANGELOG entry

@testcenter testcenter self-assigned this Jan 15, 2025
@testcenter testcenter requested a review from a team as a code owner January 15, 2025 12:11
@testcenter testcenter merged commit c3a125d into development Jan 15, 2025
3 checks passed
@testcenter testcenter deleted the PRN-154/mediaSession-destroy-fix branch January 15, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strangesource strangesource strangesource approved these changes

@rolandkakonyi rolandkakonyi rolandkakonyi approved these changes

@zigavehovec zigavehovec Awaiting requested review from zigavehovec

Assignees

@testcenter testcenter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testcenter @rolandkakonyi @strangesource