Show error if there's no secret to encode #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarcia-oss
approved these changes
Aug 19, 2024
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Not stale |
agarcia-oss
requested changes
Sep 10, 2024
agarcia-oss
added
enhancement
backlog
Signed-off-by: Alejandro Moreno <[email protected]>
Signed-off-by: Alejandro Moreno <[email protected]>
alemorcuq
force-pushed
the
error-no-secret
branch
from
58b2863 to
3eeee7b
Compare
Test case added, @agarcia-oss. |
Thanks! Looks good, @alemorcuq |
agarcia-oss
approved these changes
Oct 4, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 19, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [bitnami-labs/sealed-secrets](https://github.com/bitnami-labs/sealed-secrets) | patch | `v0.27.1` -> `v0.27.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>bitnami-labs/sealed-secrets (bitnami-labs/sealed-secrets)</summary> ### [`v0.27.2`](https://github.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0272) [Compare Source](bitnami-labs/sealed-secrets@v0.27.1...v0.27.2) - feature: Show error if there's no secret to encode ([#​1580](bitnami-labs/sealed-secrets#1580)) - feature: allow container port configuration ([#​1606](bitnami-labs/sealed-secrets#1606)) - chore: Update go version to 1.22.8 ([#​1621](bitnami-labs/sealed-secrets#1621)) - chore: Update the TCSP settings for helm testing ([#​1608](bitnami-labs/sealed-secrets#1608)) - chore: Redirect external site to the GitHub Repository ([#​1589](bitnami-labs/sealed-secrets#1589)) - chore: Update dependencies (Several automatic MRs) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Kubeseal will throw an error when trying to seal no secrets. This will happen when the file is empty or invalid, and the error suggests the user to check the file encoding as this seems to be a common issue especially in some versions of Windows #1410 #1560
Benefits
Give feedback to the user to help debugging a common issue
Possible drawbacks
Kubeseal will now throw an error where it previously just silently succeeded with no output
Applicable issues