Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: allow container port configuration #1606

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

alemorcuq
Copy link
Collaborator

Description of the change
The container and host ports are now configurable in the Helm chart. As per the docs, when hostNetwork is enabled, the host ports are set equal to the container ports.

$ kubectl explain po.spec.containers.ports

[...]
   hostPort	<integer>
     Number of port to expose on the host. If specified, this must be a valid
     port number, 0 < x < 65536. If HostNetwork is specified, this must match
     ContainerPort. Most containers do not need this.
[...]

Benefits
Users can configure the ports to use.

Possible drawbacks

Applicable issues

@alemorcuq alemorcuq force-pushed the configure-pod-ports branch from cfa14fb to 5dc2008 Compare October 4, 2024 08:22
@agarcia-oss agarcia-oss merged commit fb1b6cd into bitnami-labs:main Oct 4, 2024
16 checks passed
@alemorcuq alemorcuq deleted the configure-pod-ports branch October 4, 2024 16:23
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 19, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [bitnami-labs/sealed-secrets](https://github.com/bitnami-labs/sealed-secrets) | patch | `v0.27.1` -> `v0.27.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>bitnami-labs/sealed-secrets (bitnami-labs/sealed-secrets)</summary>

### [`v0.27.2`](https://github.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0272)

[Compare Source](bitnami-labs/sealed-secrets@v0.27.1...v0.27.2)

-   feature: Show error if there's no secret to encode ([#&#8203;1580](bitnami-labs/sealed-secrets#1580))
-   feature: allow container port configuration ([#&#8203;1606](bitnami-labs/sealed-secrets#1606))
-   chore: Update go version to 1.22.8 ([#&#8203;1621](bitnami-labs/sealed-secrets#1621))
-   chore: Update the TCSP settings for helm testing ([#&#8203;1608](bitnami-labs/sealed-secrets#1608))
-   chore: Redirect external site to the GitHub Repository ([#&#8203;1589](bitnami-labs/sealed-secrets#1589))
-   chore: Update dependencies (Several automatic MRs)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding hostport when using hostNetwork
2 participants