Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure max retries #1633

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Configure max retries #1633

merged 5 commits into from
Nov 7, 2024

Conversation

alvneiayu
Copy link
Collaborator

Description of the change

Allow to configure max retries

Applicable issues

Signed-off-by: Alvaro Neira Ayuso <[email protected]>
@alvneiayu
Copy link
Collaborator Author

PR to include the changes request on #1605

Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Copy link
Member

@agarcia-oss agarcia-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes in the README and a suggestion for the default retry behaviour

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
alvneiayu and others added 3 commits November 7, 2024 13:58
Co-authored-by: Alfredo Garcia <[email protected]>
Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Co-authored-by: Alfredo Garcia <[email protected]>
Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Copy link
Member

@agarcia-oss agarcia-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks @alvneiayu !

@alvneiayu alvneiayu merged commit e822b41 into bitnami-labs:main Nov 7, 2024
16 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 6, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [bitnami-labs/sealed-secrets](https://github.com/bitnami-labs/sealed-secrets) | patch | `v0.27.2` -> `v0.27.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>bitnami-labs/sealed-secrets (bitnami-labs/sealed-secrets)</summary>

### [`v0.27.3`](https://github.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0273)

[Compare Source](bitnami-labs/sealed-secrets@v0.27.2...v0.27.3)

-   Bump k8s.io/apimachinery from 0.31.2 to 0.31.3 ([#&#8203;1642](bitnami-labs/sealed-secrets#1642))
-   Bump k8s.io/code-generator from 0.31.2 to 0.31.3 ([#&#8203;1643](bitnami-labs/sealed-secrets#1643))
-   Bump github.com/onsi/gomega from 1.35.1 to 1.36.0 ([#&#8203;1645](bitnami-labs/sealed-secrets#1645))
-   re-introduce install instructions with to releases ([#&#8203;1649](bitnami-labs/sealed-secrets#1649))
-   Properly error out when input file doesn't exist ([#&#8203;1640](bitnami-labs/sealed-secrets#1640))
-   Bump github.com/onsi/ginkgo/v2 from 2.21.0 to 2.22.0 ([#&#8203;1641](bitnami-labs/sealed-secrets#1641))
-   Bump golang.org/x/crypto from 0.28.0 to 0.29.0 ([#&#8203;1635](bitnami-labs/sealed-secrets#1635))
-   Configure max retries ([#&#8203;1633](bitnami-labs/sealed-secrets#1633))
-   Label "app.kubernetes.io/instance" in the Prometheus metric ([#&#8203;1620](bitnami-labs/sealed-secrets#1620))
-   Bump github.com/onsi/gomega from 1.34.2 to 1.35.1 ([#&#8203;1624](bitnami-labs/sealed-secrets#1624))
-   Adding keyttl and keycutofftime options to helm chart ([#&#8203;1610](bitnami-labs/sealed-secrets#1610))
-   Bump github.com/onsi/ginkgo/v2 from 2.20.2 to 2.21.0 ([#&#8203;1623](bitnami-labs/sealed-secrets#1623))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret deleted by the garbage collector with delay
2 participants