Skip to content

Commit

Permalink
fix(react-router-busy): test if copybara shows commits that didn't af…
Browse files Browse the repository at this point in the history
…fect package

GitOrigin-RevId: e7bb0ba5b54a04c6e05d155bdbfc7e2c41782c79
  • Loading branch information
f authored and actions-user committed Sep 19, 2024
1 parent 059ad2d commit 46e9683
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/packages.react-router-busy.copy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
# Still run on push in destination repo since it might be needed
# Note PR opened in dest repo pushes commit to source repo and now it's not run, doesn't seem to matter but if it does check actor
# And when PR merged in source, it still closes PR in destination but doesn't update destination repo
if: github.event_name != 'push' || github.repository != 'bitofbreeze/mono'
# if: github.event_name != 'push' || github.repository != 'bitofbreeze/mono'
runs-on: ubuntu-latest
steps:
- name: Check out code
Expand All @@ -29,6 +29,7 @@ jobs:
sot_repo: bitofbreeze/mono
destination_repo: bitofbreeze/react-router-busy
push_files: "glob(['**'], exclude = ['apps/**', 'packages/**', '.github/workflows/*.yml']) + glob(['packages/react-router-busy/**', '.github/workflows/packages.react-router-busy.*.yml'])"
push_mode: "SQUASH"
# TODO Test if not doing squash shows commits in destination when not touching this package
push_mode: "ITERATIVE"
# Make sure to always remove init-history after first copybara push, else PRs created in destination will fail the workflow since --init-history is not compatible with CHANGE_REQUEST
# copybara_options: --init-history
15 changes: 8 additions & 7 deletions .github/workflows/packages.react-router-busy.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ name: Release

on:
# pull_request:
push:
branches:
- main
paths:
# This is fine for merging PR which is a push to main because changesets updates package's changelog and package.json to trigger this
- 'packages/react-router-busy/**'
# push:
# branches:
# - main
# paths:
# # This is fine for merging PR which is a push to main because changesets updates package's changelog and package.json to trigger this
# - 'packages/react-router-busy/**'
workflow_dispatch:

permissions:
contents: read # for checkout
Expand Down Expand Up @@ -50,7 +51,7 @@ jobs:
- name: Check exports
run: bun --filter react-router-busy check-exports
release:
# Only upsert release PR when pushing (to main)
# Only make release when pushing (to main)
if: github.event_name == 'push'
needs: [validate]
runs-on: ubuntu-latest
Expand Down

0 comments on commit 46e9683

Please sign in to comment.