-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile with test requirements #125
Conversation
I am getting one failed test on current master - is that the case for you as well when you run in your environment @bitromortac ?
|
lndmanage/lndmanage/settings.py Line 121 in 2dc2fae
The |
Added a kind of dirty fix reordering imports and setting default value for Remaining failure on run now:
|
Cool you decided to work on that. I know that one or two tests are flaky (didn't have yet time to go after it in detail), try to run them in isolation. Going to revive #84 soon, so tests could change a bit. Perhaps it would make sense to hold this back a bit. |
Ok, I pushed some raw code of how the new async tests could look like in #84. I described a bit what I'm trying to do there, feedback is welcome 🙂 |
How do I indicate which tests to run individually? I'm new to this way of testing Python and got errors doing it my naive way |
Got it. #84 still seems to have the issue with the test suite attempting to use/initiate a production config that I fixed in d60504d - would be nice if that can be resolved separately. (I'd also argue that #84 is quite big already and touches many parts and functions - making the tests run reliably separately before that, and any test overhaul not directly tied to the changes in it, would be ideal, to have higher confidence that existing functionality does not break. This includes the making-tests-async-changes. In general it's good idea to split things like that up IMO. Left a separate comment on that there as well!) |
Addressed the failing tests in #129 (should be independent of all currently open PRs) |
Superseded by #128 |
Depends on
lndmanage:local
from bitromortac/lnregtest#7