When maxWait is reached, consume return messages received so far #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bittrance
commented
Dec 2, 2024
| reader := test.module.Kafka.reader(&ReaderConfig{ | ||
| Brokers: []string{"localhost:9092"}, | ||
| Topic: test.topicName, | ||
| MaxWait: Duration{250 * time.Millisecond}, |
There was a problem hiding this comment.
We do not need 3 seconds to get down to the consume() call even on noisy Github :)
* Each test that uses a topic now creates its own. Topic names use test name and unix time, so it is easy to find and inspect it when the test fails. This also removes some offsets that worked around other tests having polluted the common topic. * Do not depend on values being shared between assert closures.
The current behavior, to panic on deadline is problematic, since there are a number of scenarios where you simply do not know how many messages there are to consume or when they are produced. For example, a load test may produce messages in bursts with jitter for a burn-in test, to try to provoke i data races in the test subject. This commit introduces a flag ExpectTimeout which will return message received so far. The commit also adds a test to verify that we panic if Close() is called while we are consuming. Given the nature of the problem xk6-kafka is trying to solve, this sounds like an errar condition.
bittrance
force-pushed
the
consume-returns-on-deadline
branch
from
e413d37 to
7b8efa7
Compare
|
Now on upstream as mostafa#313. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior, to panic on deadline is problematic, since there are a number of scenarios where you simply do not know how many messages there are to consume or when they are produced. For example, a load test may produce messages in bursts with jitter for a burn-in test, to try to provoke i data races in the test subject.
The commit also adds a test to verify that we panic if Close() is called while we are consuming. Given the nature of the problem xk6-kafka is trying to solve, this sounds like an errar condition.