BWA-118 - Tutorial text cut off in landscape mode #299
+529
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-livefront
requested review from
brian-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
app/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/tutorial/TutorialScreen.kt
Outdated
Show resolved
Hide resolved
| modifier = Modifier | ||
| .standardHorizontalMargin(landscape = LANDSCAPE_HORIZONTAL_MARGIN) | ||
| .fillMaxWidth() | ||
| .alpha(if (state.isLastPage) 0f else 1f) |
There was a problem hiding this comment.
This is technically still clickable, should we disable it too?
There was a problem hiding this comment.
isEnabled = !state.isLastPage,
Won't this prevent click events?
There was a problem hiding this comment.
Ohh, I missed that. We should be good
| .padding(bottom = 12.dp), | ||
| ) | ||
|
|
||
| Spacer(modifier = Modifier.navigationBarsPadding()) |
| /** | ||
| * The custom horizontal margin that is specific to this screen. | ||
| */ | ||
| private val LANDSCAPE_HORIZONTAL_MARGIN: Dp = 128.dp |
david-livefront
approved these changes
Dec 10, 2024
SaintPatrck
approved these changes
Dec 11, 2024
phil-livefront
deleted the
phil/BWA-118-tutorial-text-cut-off-in-landscape-mode
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BWA-118
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes