-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14954] implement multi input totp styling #12449
[PM-14954] implement multi input totp styling #12449
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12449 +/- ##
==========================================
+ Coverage 34.28% 34.30% +0.02%
==========================================
Files 2933 2933
Lines 90081 90128 +47
Branches 16916 16926 +10
==========================================
+ Hits 30886 30921 +35
- Misses 56737 56745 +8
- Partials 2458 2462 +4 ☔ View full report in Codecov by Sentry. |
apps/browser/src/autofill/background/overlay.background.spec.ts
Outdated
Show resolved
Hide resolved
/** | ||
* Determines if the current rect values are not all 0. | ||
*/ | ||
export function rectNotZero(rect: FieldRect): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking nit; a non-negative function name (e.g. rectHasSize
or rectIsZero
and invert logic) could improve readability
BIT is failing on notification tests, but it also fails on
I manually tested the notification bar cases with the build + flags, and it looks good, and I'll create a follow up task to fix BIT |
apps/browser/src/autofill/services/autofill-overlay-content.service.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonathan Prusik <[email protected]>
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14954
📔 Objective
Updates multi-input totp field styling for autofill dropdown and button
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes