Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14954] implement multi input totp styling #12449

Merged
merged 18 commits into from
Jan 13, 2025

Conversation

evan-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14954

📔 Objective

Updates multi-input totp field styling for autofill dropdown and button

📸 Screenshots

Screenshot 2024-12-17 at 2 25 32 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@evan-livefront evan-livefront requested a review from a team as a code owner December 17, 2024 20:30
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Logo
Checkmarx One – Scan Summary & Detailsad89a622-d641-4d38-8f81-9e6c7fe23025

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes missing coverage. Please review.

Project coverage is 34.30%. Comparing base (a54508a) to head (f5f15f9).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...wser/src/autofill/background/overlay.background.ts 80.00% 5 Missing and 3 partials ⚠️
apps/browser/src/autofill/utils/index.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12449      +/-   ##
==========================================
+ Coverage   34.28%   34.30%   +0.02%     
==========================================
  Files        2933     2933              
  Lines       90081    90128      +47     
  Branches    16916    16926      +10     
==========================================
+ Hits        30886    30921      +35     
- Misses      56737    56745       +8     
- Partials     2458     2462       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jprusik
Copy link
Contributor

jprusik commented Jan 7, 2025

/**
* Determines if the current rect values are not all 0.
*/
export function rectNotZero(rect: FieldRect): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking nit; a non-negative function name (e.g. rectHasSize or rectIsZero and invert logic) could improve readability

@jprusik
Copy link
Contributor

jprusik commented Jan 7, 2025

BIT run: https://github.com/bitwarden/browser-interactions-testing/actions/runs/12654753571

BIT is failing on notification tests, but it also fails on main with the same feature flags:

{"extension-refresh": true, "inline-menu-field-qualification": true, "inline-menu-positioning-improvements": true, "inline-menu-totp": true}

I manually tested the notification bar cases with the build + flags, and it looks good, and I'll create a follow up task to fix BIT

jprusik
jprusik previously approved these changes Jan 7, 2025
@evan-livefront evan-livefront merged commit d471fe0 into main Jan 13, 2025
34 of 35 checks passed
@evan-livefront evan-livefront deleted the autofill/PM-14954-implement-multi-input-totp branch January 13, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants