Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15999] - use new generator components in desktop app #12639

Merged
merged 9 commits into from
Jan 6, 2025

use static method for opening dialog

1ce63ae
Select commit
Loading
Failed to load commit list.
Merged

[PM-15999] - use new generator components in desktop app #12639

use static method for opening dialog
1ce63ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2025 in 0s

33.72% (-0.05%) compared to 75f75dc

View this Pull Request on Codecov

33.72% (-0.05%) compared to 75f75dc

Details

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.72%. Comparing base (75f75dc) to head (1ce63ae).
Report is 30 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...app/vault/credential-generator-dialog.component.ts 0.00% 20 Missing โš ๏ธ
...pps/desktop/src/vault/app/vault/vault.component.ts 0.00% 14 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12639      +/-   ##
==========================================
- Coverage   33.76%   33.72%   -0.05%     
==========================================
  Files        2912     2919       +7     
  Lines       90791    91026     +235     
  Branches    17177    17207      +30     
==========================================
+ Hits        30655    30696      +41     
- Misses      57743    57930     +187     
- Partials     2393     2400       +7     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.