Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Adjust for a breaking change in the Slack action #12753

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

addisonbeck
Copy link
Contributor

@addisonbeck addisonbeck commented Jan 8, 2025

🎟️ Tracking

#12140

📔 Objective

On the linked PR I updated the Slack action dependency used to send notifications to QA about new desktop builds. I had missed a couple of relevant breaking changes for the new version:

The Slack API method now must be specified in inputs

This Action now requires that the Slack API method is specified in inputs.

Prior to updating: Messages would be posted using chat.postMessage or chat.update behind the scenes.

Recommend change: Use the method that matches the message being posted, or use a different method:
A token must be provided with other inputs

This Action expects a token as a step input value.

Prior to updating: Bot tokens were provided with the SLACK_BOT_TOKEN environment variable.

Recommended change: Provide the token scoped for the method as a step input, as shown above. The SLACK_TOKEN environment variable can also be used.

This commit adjusts our use of this action to account for these breaking changes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@addisonbeck addisonbeck marked this pull request as ready for review January 8, 2025 16:09
@addisonbeck addisonbeck requested a review from a team as a code owner January 8, 2025 16:09
@addisonbeck addisonbeck requested review from coroiu and Hinton January 8, 2025 16:09
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One – Scan Summary & Details2b522196-e9c9-4e60-a511-3f8d3db858e7

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /libs/vault/src/components/decryption-failure-dialog/decryption-failure-dialog.component.html: 17 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/settings/trash-list-items-container/trash-list-items-container.component.ts: 47 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/settings/trash-list-items-container/trash-list-items-container.component.ts: 47 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/settings/trash-list-items-container/trash-list-items-container.component.ts: 52 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/settings/trash-list-items-container/trash-list-items-container.component.ts: 52 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 25 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 25 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 25 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 25 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 25 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/vault/src/components/decryption-failure-dialog/decryption-failure-dialog.component.html: 17
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/settings/trash-list-items-container/trash-list-items-container.component.html: 6
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html: 53
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html: 31

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.14%. Comparing base (48f9909) to head (b3e1a16).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12753   +/-   ##
=======================================
  Coverage   34.13%   34.14%           
=======================================
  Files        2937     2937           
  Lines       90337    90337           
  Branches    16961    16961           
=======================================
+ Hits        30839    30846    +7     
+ Misses      57043    57036    -7     
  Partials     2455     2455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@addisonbeck addisonbeck enabled auto-merge (squash) January 8, 2025 18:37
@addisonbeck addisonbeck merged commit a9ca361 into main Jan 8, 2025
38 of 39 checks passed
@addisonbeck addisonbeck deleted the fix-ci branch January 8, 2025 18:47
@addisonbeck addisonbeck restored the fix-ci branch January 9, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants