Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17530] delete obsolete registration component #13181

Merged

Conversation

alec-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17530?atlOrigin=eyJpIjoiMDBjYjYzM2FjZjBjNGY5ZGE3NWUyZDM4MTk1YTI3MGIiLCJwIjoiaiJ9

📔 Objective

Removes old registration components. Also includes changes from #12862

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Logo
Checkmarx One – Scan Summary & Detailsd392b497-9a88-486b-a952-bd9069e1ec80

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.28%. Comparing base (a038371) to head (e16ca5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13181      +/-   ##
==========================================
+ Coverage   35.20%   35.28%   +0.08%     
==========================================
  Files        3127     3124       -3     
  Lines       92568    92358     -210     
  Branches    16857    16794      -63     
==========================================
  Hits        32590    32590              
+ Misses      57521    57311     -210     
  Partials     2457     2457              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alec-livefront alec-livefront marked this pull request as ready for review February 4, 2025 19:18
@alec-livefront alec-livefront requested a review from a team as a code owner February 4, 2025 19:18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alec-livefront alec-livefront enabled auto-merge (squash) February 11, 2025 16:03
@alec-livefront alec-livefront merged commit 1685f67 into main Feb 11, 2025
87 of 88 checks passed
@alec-livefront alec-livefront deleted the auth/pm-17530/delete-obsolete-registration-component branch February 11, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants