-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17530] delete obsolete registration component #13181
[PM-17530] delete obsolete registration component #13181
Conversation
…d-components-on-web' into pm-7317-clean-up-old-components-on-web
…d-components-on-web' into pm-7317-clean-up-old-components-on-web
…d-components-on-web' into pm-7317-clean-up-old-components-on-web
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13181 +/- ##
==========================================
+ Coverage 35.20% 35.28% +0.08%
==========================================
Files 3127 3124 -3
Lines 92568 92358 -210
Branches 16857 16794 -63
==========================================
Hits 32590 32590
+ Misses 57521 57311 -210
Partials 2457 2457 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17530?atlOrigin=eyJpIjoiMDBjYjYzM2FjZjBjNGY5ZGE3NWUyZDM4MTk1YTI3MGIiLCJwIjoiaiJ9
📔 Objective
Removes old registration components. Also includes changes from #12862
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes