[PM-15994] Move encrypt service to km ownership #13220
Merged
+240
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues (79)Great job! The following issues were fixed in this Pull Request
|
quexten
requested review from
audreyality,
JimmyVo16,
shane-melton,
cturnbull-bitwarden,
Patrick-Pimentel-Bitwarden,
jprusik and
mzieniukbw
coroiu
previously approved these changes
Feb 4, 2025
Patrick-Pimentel-Bitwarden
previously approved these changes
Feb 4, 2025
| @@ -1,7 +1,7 @@ | |||
| import { mock, MockProxy } from "jest-mock-extended"; | |||
|
|
|||
| import { makeEncString, makeSymmetricCryptoKey } from "../../../../spec"; | |||
| import { EncryptService } from "../../abstractions/encrypt.service"; | |||
| import { EncryptService } from "../../../key-management/crypto/abstractions/encrypt.service"; | |||
There was a problem hiding this comment.
There are still some relative imports for EncryptService, is that worth taking another look at?
| @@ -23,13 +23,13 @@ import { AccountService } from "../../auth/abstractions/account.service"; | |||
| import { AutofillSettingsServiceAbstraction } from "../../autofill/services/autofill-settings.service"; | |||
| import { DomainSettingsService } from "../../autofill/services/domain-settings.service"; | |||
| import { FeatureFlag } from "../../enums/feature-flag.enum"; | |||
| import { BulkEncryptService } from "../../key-management/crypto/abstractions/bulk-encrypt.service"; | |||
There was a problem hiding this comment.
Relative import for the BulkEncryptService, is this worth taking a second look at?
quexten
dismissed stale reviews from JimmyVo16, shane-melton, audreyality, coltonhurst, Patrick-Pimentel-Bitwarden, and coroiu
via
e9c477e
|
Seems there was already a conflict. Resolved! |
quexten
requested review from
coroiu,
audreyality,
shane-melton,
cyprain-okeke,
mzieniukbw,
Patrick-Pimentel-Bitwarden,
JimmyVo16 and
coltonhurst
and removed request for
jprusik
coroiu
approved these changes
Feb 5, 2025
mzieniukbw
approved these changes
Feb 5, 2025
|
Note for reviewers: The codecov fail is accepted since this is just a service move of a service to km ownership. The build failure is unrelated and failing in all PR's currently. |
Patrick-Pimentel-Bitwarden
approved these changes
Feb 5, 2025
coltonhurst
approved these changes
Feb 5, 2025
JimmyVo16
approved these changes
Feb 5, 2025
cturnbull-bitwarden
approved these changes
Feb 5, 2025
shane-melton
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15994
📔 Objective
Moves the encrypt services and encrypt service worker to KM ownership.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes