Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17184] Remove Bootstrap style from EmergencyAccessComponent #13247

Conversation

alec-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17184?atlOrigin=eyJpIjoiNWY5M2NjNTFiMmIxNDU4MWI1MTNjNGY0NjhjYjE1YTciLCJwIjoiaiJ9

📔 Objective

Replaces Bootstrap styles in the EmergencyAccessComponent component with Tailwind equivalents.

📸 Screenshots

Screenshot 2025-02-04 at 11 15 13 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Logo
Checkmarx One – Scan Summary & Details8ccd74ab-d9a5-476d-9b4a-07270f57420e

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.21%. Comparing base (a038371) to head (188d5b1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13247   +/-   ##
=======================================
  Coverage   35.20%   35.21%           
=======================================
  Files        3127     3127           
  Lines       92568    92568           
  Branches    16857    16857           
=======================================
+ Hits        32590    32597    +7     
+ Misses      57521    57514    -7     
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alec-livefront alec-livefront merged commit ed0b8d1 into main Feb 11, 2025
49 checks passed
@alec-livefront alec-livefront deleted the auth/pm-17184/remove-bootstrap-style-from-EmergencyAccessComponent branch February 11, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants